Skip to content

Mark windows-gnu* as lacking build with assertions #149507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Mark windows-gnu* as lacking build with assertions #149507

wants to merge 1 commit into from
+2 −6

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Dec 1, 2025

Knowing that x86_64-pc-windows-gnu has no builds with assertions, I have just copied it as x86_64-pc-windows-gnullvm and called a day. Obviously it should have been false, sorry for that.
While at it, also fix x86_64-pc-windows-gnu.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 1, 2025
@mati865
Copy link
Member Author

mati865 commented Dec 1, 2025

@bors try jobs=dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2

@rust-bors
Copy link

rust-bors bot commented Dec 1, 2025 •
edited
Loading

⌛ Trying commit 57a1000 with merge 4837fd3…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19827299126

rust-bors bot added a commit that referenced this pull request Dec 1, 2025
@rust-bors
Auto merge of #149507 - mati865:windows-gnu-like-no-asserts, r=<try>
4837fd3 
Mark windows-gnu* as lacking build with assertions

try-job: dist-x86_64-llvm-mingw
try-job: dist-x86_64-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mati865 @rustbot