Skip to content

Stop adding MSYS2 to PATH #149516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop adding MSYS2 to PATH #149516

wants to merge 1 commit into from
+0 −14

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Dec 1, 2025 •
edited
Loading

Rust no longer requires MSYS2 provided tools like make.

@mati865
Stop adding MSYS2 to PATH
662192a 
Rust no longer requires MSYS2 tools like make.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 1, 2025
@mati865
Copy link
Member Author

mati865 commented Dec 1, 2025

@bors try jobs=dist-i686-mingw,dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 1, 2025
@rust-bors
Auto merge of #149516 - mati865:no-msys2, r=<try>
985933c 
Stop adding MSYS2 to PATH

try-job: dist-i686-mingw
try-job: dist-x86_64-llvm-mingw
try-job: dist-x86_64-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-bors
Copy link

rust-bors bot commented Dec 1, 2025

☀️ Try build successful (CI)
Build commit: 985933c (985933c5806c18741cc07431a6c7eb14bbf67677, parent: 2fb805367dd3012ce5c50865d03c86e70bf10f0f)

@mati865 mati865 marked this pull request as ready for review December 1, 2025 21:02
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mati865 @rustbot @Mark-Simulacrum