Skip to content

Generate delegation error body when delegation is not resolved #149548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Generate delegation error body when delegation is not resolved #149548

wants to merge 2 commits into from
+84 −6

Conversation

@aerooneqq
Copy link
Contributor

@aerooneqq aerooneqq commented Dec 2, 2025 •
edited by rustbot
Loading

This PR relates to the delegation feature #118212, it fixes #144594 ICE.
r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2025
@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Dec 2, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 2, 2025

Maybe it's better to fix check_unused_traits/lint_level_id_at_node somehow, instead of generation more detailed recovery HIR.
We don't generally require for all DefIds to appear in HIR (that's why MaybeOwner::Phantom exists), so the issue may potentially reproduce on something else than delegation.
Needs some investigation.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE: delegation: No HirId for DefId

3 participants

@aerooneqq @petrochenkov @rustbot