-
Notifications
You must be signed in to change notification settings - Fork 14.1k
added default_uwtables=true to aarch64_unknown_none targets #149553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BartMassey
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
BartMassey-upstream:aarch64-none-default-uwtables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added default_uwtables=true to aarch64_unknown_none targets #149553
BartMassey
wants to merge
1
commit into
rust-lang:main
from
BartMassey-upstream:aarch64-none-default-uwtables
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
wesleywiser
approved these changes
Dec 2, 2025
Member
|
@bors r+ rollup |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 3, 2025
…efault-uwtables, r=wesleywiser added default_uwtables=true to aarch64_unknown_none targets This patch adds DWARF unwinding tables by default for `aarch64-unknown-none` and `aarch64-unknown-none-softfloat` targets. By implication, the `core` library for these targets will be built with unwinding tables. These tables are often useful, and are especially needed for backtracing through `core` on embedded targets. The tables can be turned off for user compilation with `-C force-unwind-tables=no` if desired. (I am the lead maintainer for these targets in the Rust Embedded Working Group, and have discussed this with REWG.)
bors
added a commit
that referenced
this pull request
Dec 3, 2025
Rollup of 3 pull requests Successful merges: - #148937 (Remove initialized-bytes tracking from `BorrowedBuf` and `BorrowedCursor`) - #149553 (added default_uwtables=true to aarch64_unknown_none targets) - #149578 (rustdoc: Fix broken link to `Itertools::format`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 3, 2025
Rollup of 3 pull requests Successful merges: - #148937 (Remove initialized-bytes tracking from `BorrowedBuf` and `BorrowedCursor`) - #149553 (added default_uwtables=true to aarch64_unknown_none targets) - #149578 (rustdoc: Fix broken link to `Itertools::format`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds DWARF unwinding tables by default for
aarch64-unknown-noneandaarch64-unknown-none-softfloattargets. By implication, thecorelibrary for these targets will be built with unwinding tables. These tables are often useful, and are especially needed for backtracing throughcoreon embedded targets. The tables can be turned off for user compilation with-C force-unwind-tables=noif desired.(I am the lead maintainer for these targets in the Rust Embedded Working Group, and have discussed this with REWG.)