Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 4, 2025

This PR changes two things:

  • This decouples the AttributeLintKind from the Lint it is emitted in. cx.emit_lint now takes both as an argument, rather than inferring the Lint from the AttributeLintKind. This is nice because:
    • It allows us to remove AttributeLintKind::InvalidMacroExportArguments
    • It allows us to move the choice between USELESS_DEPRECATED and UNUSED_ATTRIBUTES out of the lint emitting code
    • It allows the next change:
  • This moves AttributeLintKind to rustc_lint_defs, and the decorating code to rustc_lint. This is nice because:

This PR does not change observable output of the compiler, as can be seen by no uitests being affected.

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Dec 4, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2025
@bors
Copy link
Collaborator

bors commented Dec 5, 2025

☔ The latest upstream changes (presumably #149646) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#3 [auth] library/ubuntu:pull token for registry-1.docker.io
#3 DONE 0.0s

#4 [internal] load metadata for docker.io/library/ubuntu:25.10
#4 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928063&signature=Sp2rn%2F6WtvvEjwrKu%2Ft%2BdZTWEps%3D&version=2: 500 Internal Server Error
------
 > [internal] load metadata for docker.io/library/ubuntu:25.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:25.10
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to build: failed to solve: ubuntu:25.10: failed to resolve source metadata for docker.io/library/ubuntu:25.10: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928063&signature=Sp2rn%2F6WtvvEjwrKu%2Ft%2BdZTWEps%3D&version=2: 500 Internal Server Error
Command failed. Attempt 2/5:
#0 building with "great_hermann" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.26kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:25.10
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928072&signature=NQojeHMS5uMDjLPKAyoxlJpWQVc%3D&version=2: 500 Internal Server Error
------
 > [internal] load metadata for docker.io/library/ubuntu:25.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:25.10
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to build: failed to solve: ubuntu:25.10: failed to resolve source metadata for docker.io/library/ubuntu:25.10: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928072&signature=NQojeHMS5uMDjLPKAyoxlJpWQVc%3D&version=2: 500 Internal Server Error
Command failed. Attempt 3/5:
#0 building with "great_hermann" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.26kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:25.10
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928082&signature=cCTl2ULklPz1yKsPsr8FmqQyDIE%3D&version=2: 500 Internal Server Error
------
 > [internal] load metadata for docker.io/library/ubuntu:25.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:25.10
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to build: failed to solve: ubuntu:25.10: failed to resolve source metadata for docker.io/library/ubuntu:25.10: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928082&signature=cCTl2ULklPz1yKsPsr8FmqQyDIE%3D&version=2: 500 Internal Server Error
Command failed. Attempt 4/5:
#0 building with "great_hermann" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.26kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:25.10
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928093&signature=td3W7aOHTWC7rD4wcpXIQPtGM9w%3D&version=2: 500 Internal Server Error
------
 > [internal] load metadata for docker.io/library/ubuntu:25.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:25.10
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to build: failed to solve: ubuntu:25.10: failed to resolve source metadata for docker.io/library/ubuntu:25.10: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928093&signature=td3W7aOHTWC7rD4wcpXIQPtGM9w%3D&version=2: 500 Internal Server Error
Command failed. Attempt 5/5:
#0 building with "great_hermann" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.26kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:25.10
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928105&signature=UqUpYSOzSTZpg2dmftN5EAkIXO4%3D&version=2: 500 Internal Server Error
------
 > [internal] load metadata for docker.io/library/ubuntu:25.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:25.10
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to build: failed to solve: ubuntu:25.10: failed to resolve source metadata for docker.io/library/ubuntu:25.10: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/7d/7dbdfc54fb144cd7ea53791c299eda9777ace31bd25e16d999b83b4bfc5dc728/data?expires=1764928105&signature=UqUpYSOzSTZpg2dmftN5EAkIXO4%3D&version=2: 500 Internal Server Error
The command has failed after 5 attempts.
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants