-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Move attribute lints to rustc_lint
#149662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some changes occurred in compiler/rustc_attr_parsing These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
☔ The latest upstream changes (presumably #149646) made this pull request unmergeable. Please resolve the merge conflicts. |
f10523e to
942e4b2
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This PR changes two things:
AttributeLintKindfrom theLintit is emitted in.cx.emit_lintnow takes both as an argument, rather than inferring theLintfrom theAttributeLintKind. This is nice because:AttributeLintKind::InvalidMacroExportArgumentsUSELESS_DEPRECATEDandUNUSED_ATTRIBUTESout of the lint emitting codeAttributeLintKindtorustc_lint_defs, and the decorating code torustc_lint. This is nice because:check-cfglints torustc_attr_parsing#149215IllFormedAttributeInputThis PR does not change observable output of the compiler, as can be seen by no uitests being affected.
r? @jdonszelmann