Skip to content

Statically require links to an issue or the edition guide for all FCWs #149846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jdonszelmann wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Statically require links to an issue or the edition guide for all FCWs #149846

jdonszelmann wants to merge 4 commits into from
+385 −296

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Dec 10, 2025

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 10, 2025
jdonszelmann
jdonszelmann commented Dec 10, 2025
View reviewed changes
tests/ui/anon-params/anon-params-deprecated.stderr
|
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
= note: for more information, see issue #41686 <https://github.com/rust-lang/rust/issues/41686>
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2018/trait-fn-parameters.html>
Copy link
Contributor Author

@jdonszelmann jdonszelmann Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all 2018 edition FCWs had links to issues while there's a perfectly good edition guide page available

jdonszelmann
jdonszelmann commented Dec 10, 2025
View reviewed changes
tests/ui/macros/non-fmt-panic.stderr
LL | panic!("here's a brace: {");
| ^
|
= note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/panic-macro-consistency.html>
Copy link
Contributor Author

@jdonszelmann jdonszelmann Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example of an FCW without link

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU
Copy link
Member

BoxyUwU commented Dec 10, 2025

are there edition guide pages before an edition is done? like how does this work when the next edition is a WIP still

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Dec 10, 2025

This is fair. We currently aren't in that situation. The types model the current situation, but it's trivial to make the edition-related FCW an enum of either an issue or an edition guide page. I could do this now, or whenever that's relevant in the future.

@BoxyUwU
Copy link
Member

BoxyUwU commented Dec 10, 2025

Probably makes sense to do so now so that any future efforts for editions don't get blocked on misc-infra work

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Dec 10, 2025

I feel like since we have a concept of a "future" edition, it also makes sense to have pages in the edition guide for the changes in that "future" edition.

WaffleLapkin
WaffleLapkin reviewed Dec 10, 2025
View reviewed changes
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Dec 10, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2025
WaffleLapkin
WaffleLapkin approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit and ci

View changes since this review

src/doc/rustc-dev-guide/src/bug-fix-procedure.md Outdated
.emit();
```

Or better: a structured like this:
Copy link
Member

@WaffleLapkin WaffleLapkin Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure what this sentence means. A structured what?..

@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Dec 10, 2025

@bors r=wafflelapkin

@bors
Copy link
Collaborator

bors commented Dec 10, 2025

📌 Commit 183048c has been approved by wafflelapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2025
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Dec 10, 2025

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 10, 2025
@matthiaskrgr
Rollup merge of rust-lang#149846 - jdonszelmann:links-for-all-fcws, r…
eab1036 
…=wafflelapkin

Statically require links to an issue or the edition guide for all FCWs

r? `@wafflelapkin`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2025
Open
bors added a commit that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149853 - matthiaskrgr:rollup-m2rkwqr, r=matthiaskrgr
bfd0918 
Rollup of 7 pull requests

Successful merges:

 - #148052 (Stabilize `const_mul_add`)
 - #149386 (Display funding link in the github overview)
 - #149489 (Experimentally add *heterogeneous* `try` blocks)
 - #149764 (Make `--print=backend-has-zstd` work by default on any backend)
 - #149838 (Build auxiliary in pretty tests)
 - #149839 (Use `PointeeSized` bound for `TrivialClone` impls)
 - #149846 (Statically require links to an issue or the edition guide for all FCWs)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels

A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jdonszelmann @rustbot @rust-log-analyzer @BoxyUwU @WaffleLapkin @bors