-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Crater run for cargo build-dir changes #149852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Crater run for cargo build-dir changes #149852
Conversation
|
Some changes occurred in src/tools/cargo cc @ehuss |
|
|
Do you happen to know the crater command you want to run? (The command syntax is documented at https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md) |
|
Let's do @bors try |
|
⌛ Trying commit f5c22ed with merge 3117848… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/20106890373 |
…, r=<try> Crater run for cargo build-dir changes
|
@Kivooeo IIUC, that's not going to be sufficient for this because the new layout is not enabled by default. There may be some special settings like environment variables that will be needed to test this properly. And as for the mode, I suspect we want to build, not check, because we'll want to see if build scripts or proc-macros are doing any shenanigans that are required for linking correctly. (Or maybe |
PR for crater run of rust-lang/cargo#16336
Before running, we should probably get a sanity check from @epage that there is nothing I missed.
See Zulip Thread
r? @Mark-Simulacrum