Skip to content

Conversation

@ranger-ross
Copy link
Member

PR for crater run of rust-lang/cargo#16336
Before running, we should probably get a sanity check from @epage that there is nothing I missed.

See Zulip Thread

r? @Mark-Simulacrum

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

⚠️ Warning ⚠️

@ehuss
Copy link
Contributor

ehuss commented Dec 10, 2025

Do you happen to know the crater command you want to run? (The command syntax is documented at https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md)

@Kivooeo
Copy link
Member

Kivooeo commented Dec 10, 2025

Let's do try first and then run crater in check-only mode, at least this is how I understand this process

@bors try

@rust-bors
Copy link

rust-bors bot commented Dec 10, 2025

⌛ Trying commit f5c22ed with merge 3117848

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/20106890373

rust-bors bot added a commit that referenced this pull request Dec 10, 2025
…, r=<try>

Crater run for cargo build-dir changes
@ehuss
Copy link
Contributor

ehuss commented Dec 10, 2025

@Kivooeo IIUC, that's not going to be sufficient for this because the new layout is not enabled by default. There may be some special settings like environment variables that will be needed to test this properly. And as for the mode, I suspect we want to build, not check, because we'll want to see if build scripts or proc-macros are doing any shenanigans that are required for linking correctly. (Or maybe test I don't know.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants