Rollup of 4 pull requests #149872
Closed
Rollup of 4 pull requests #149872
+200
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to show/hide implementors
…=yotamofek Put negative implementors first and apply same ordering logic to foreign implementors Fixes rust-lang#51129. This PR changeda surprisingly small amount of things to put negative trait impls before the others: basically just adding a new information in the generated JS file for foreign implementors and a "negative marker" DOM element to know where to insert negative impls. I also used this occasion to make the foreign implementors sort the same as the local ones by using `compare_names`. You can test it [here](https://rustdoc.crud.net/imperio/neg-implementors/core/marker/trait.Sync.html#implementors). r? `@notriddle`
Use ubuntu:24.04 for the `x86_64-gnu-miri` job Ralf asked for this in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Adding.20a.20C.2B.2B.20dependency.20to.20Miri.3F/with/560654845.
…yotamofek Remove "tidy" tool for `tests/rustdoc` testsuite As discussed in the [last rustdoc meeting](https://rust-lang.zulipchat.com/#narrow/channel/393423-t-rustdoc.2Fmeetings/topic/2025-12-08/near/562554410), it seems like the current `tidy` tool is not used much for the `rustdoc` testsuite by the rustdoc contributors as it doesn't fit nicely our needs. Until we find something better, we decided to remove it. r? `@yotamofek`
only resolve main in bin crates Fixes rust-lang#149412
rustbot
added
A-CI
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 11, 2025
Rollup of 4 pull requests Successful merges: - #142380 (Put negative implementors first and apply same ordering logic to foreign implementors) - #149807 (Use ubuntu:24.04 for the `x86_64-gnu-miri` job) - #149850 (Remove "tidy" tool for `tests/rustdoc` testsuite) - #149867 (only resolve main in bin crates) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Contributor
bors
added
S-waiting-on-author
rustbot
removed
the
S-waiting-on-author
Member
Author
|
Yeah, that was an unusually long delay between queueing and trying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
x86_64-gnu-mirijob #149807 (Use ubuntu:24.04 for thex86_64-gnu-mirijob)tests/rustdoctestsuite #149850 (Remove "tidy" tool fortests/rustdoctestsuite)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup