rustc_codegen_llvm: update alignment for double on AIX #149880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These commits modify compiler targets. |
rustbot
added
A-LLVM
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
the
llvm-main
This comment has been minimized.
This comment has been minimized.
This was recently fixed upstream in LLVM, so we update our default layout to match. @rustbot label: +llvm-main
durin42
force-pushed
the
llvm-22-ppc-aix-layout
branch
from
cd5658e to
2968372
Compare
nikic
reviewed
Dec 15, 2025
| } | ||
| if sess.target.arch == Arch::PowerPC64 { | ||
| // LLVM 22 updated the ABI alignment for double on AIX: https://github.com/llvm/llvm-project/pull/144673 | ||
| target_data_layout = target_data_layout.replace("64-f64:32:", ""); |
Contributor
There was a problem hiding this comment.
Can you replace something like -f64:32:64 instead? This replacement across different data layout elements is weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was recently fixed upstream in LLVM, so we update our default layout to match.
@rustbot label: +llvm-main