miri: add -Zbinary-dep-depinfo to dependency builds #149882
Conversation
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
src/tools/miri/tests/ui.rs
Outdated
| // There is no `cargo miri build` so we just use `cargo miri run`. | ||
| args: ["miri", "run"].into_iter().map(Into::into).collect(), | ||
| // Add `-Zbinary-dep-depinfo` since it is needed for bootstrap builds (and doesn't harm otherwise). | ||
| args: ["miri", "run", "-Zbinary-dep-depinfo"] |
There was a problem hiding this comment.
@oli-obk this made me realize that we are overwriting the default arguments here: --color=never --quiet --jobs 1. Apparently things also work without these flags. In particular the -j1 is odd though -- why are parallel builds disabled by default and it is a potential issue that Miri does not disable them?
RalfJung
force-pushed
the
miri-dep-build
branch
from
564baf0 to
0428dd5
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| // Ensure we rebuild the dependencies when the sysroot changes. | ||
| // (Bootstrap usually sets this automatically, but since we invoke cargo | ||
| // ourselves we have to do it.) | ||
| p.args.push("-Zbinary-dep-depinfo".into()); |
There was a problem hiding this comment.
I figured I would do the same thing on the clippy side as well, since it's basically the same setup as Miri.
3 participants
Hopefully fixes #149711
Cc @bjorn3