Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 12, 2025

r? @jdonszelmann

Fixes one of the todos from #149865

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2025
@jdonszelmann
Copy link
Contributor

this is awesome work! thanks :) Finally getting rid of some old attr code

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

📌 Commit acea7df has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2025
…=jdonszelmann

Remove unused code in `cfg_old`

r? `@jdonszelmann`

Fixes one of the todos from rust-lang#149865
@matthiaskrgr
Copy link
Member

@bors r-
#149905 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2025
@matthiaskrgr
Copy link
Member

@bors try job=aarch64-gnu-llvm-20-2

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

Unknown argument "job". Run @bors2 help to see available commands.

@matthiaskrgr
Copy link
Member

@bors2 try jobs=aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 12, 2025
Remove unused code in `cfg_old`

try-job: aarch64-gnu-llvm-20-2
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

💔 Test for ea469cb failed: CI. Failed jobs:

@JonathanBrouwer
Copy link
Contributor Author

@bors2 try jobs=aarch64-gnu-llvm-20-2

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

⌛ Trying commit 322e0f7 with merge 44d7933

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/20165191266

rust-bors bot added a commit that referenced this pull request Dec 12, 2025
Remove unused code in `cfg_old`

try-job: aarch64-gnu-llvm-20-2
@JonathanBrouwer
Copy link
Contributor Author

Why did PR ci not catch that failure btw?

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0536::_::Note__this_error_code_is_no_longer_emitted_by_the_compiler_ (line 11285)

test result: FAILED. 1040 passed; 1 failed; 73 ignored; 0 measured; 0 filtered out; finished in 23.83s

Command `/checkout/obj/build/bootstrap/debug/rustdoc -Wrustdoc::invalid_codeblock_attributes -Dwarnings -Znormalize-docs -Z unstable-options --test /checkout/obj/build/aarch64-unknown-linux-gnu/test/error-index.md --test-args ` failed with exit code 101
Created at: src/bootstrap/src/core/builder/mod.rs:1476:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:2774:13

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 0:37:40
  local time: Fri Dec 12 12:05:15 UTC 2025
  network time: Fri, 12 Dec 2025 12:05:15 GMT
##[error]Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants