Skip to content

Add a sanity check in case of any duplicate nodes #149916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zetanumbers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a sanity check in case of any duplicate nodes #149916

zetanumbers wants to merge 2 commits into from
+7 −2

Conversation

@zetanumbers
Copy link
Contributor

@zetanumbers zetanumbers commented Dec 12, 2025 •
edited
Loading

A simple check in case compiler tries to encode a dep node twice like in #141540.

Also if we'd try to mark a red node as green as it may then create a bad DepNodeIndex like in #148295.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@zetanumbers
Copy link
Contributor Author

zetanumbers commented Dec 12, 2025

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned jdonszelmann Dec 12, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 12, 2025

r=me once CI is green

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 12, 2025

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 12, 2025

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025 •
edited
Loading

⌛ Trying commit c7b5fb5 with merge 932e85d…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/20171519528

rust-bors bot added a commit that referenced this pull request Dec 12, 2025
@rust-bors
Auto merge of #149916 - zetanumbers:double_node_sanity, r=<try>
932e85d 
Add a sanity check in case of any duplicate nodes
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zetanumbers @rustbot @petrochenkov @matthiaskrgr @rust-timer @jdonszelmann