Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Follow-up of #149645.

The change I made was slightly wrong. Originally the check was:

        if let Some(item_list) = attr.meta_item_list() {
            for item in item_list {
                if !item.has_name(sym::inline) {

So we were checking that there was no doc(inline) attribute. This PR should fix it.

r? @lqd

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2025
@fmease
Copy link
Member

fmease commented Dec 12, 2025

Is this regression user observable? If so, it would be nice to add a test exercising it.

@GuillaumeGomez
Copy link
Member Author

Would be nice indeed. Gonna try to trigger a bug with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants