Support recursive delegation #150024
Open
Support recursive delegation #150024
+347
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| if visited.contains(&node_id) { | ||
| // We encountered a cycle in the resolution, or delegation callee refers to non-existent | ||
| // entity, in this case emit an error. | ||
| return Err(self.dcx().emit_err(UnresolvedDelegationCallee { span })); |
Contributor
There was a problem hiding this comment.
The error wording here is particularly bad, it doesn't say anything about encountering a cycle, but says that there's a resolution error, which is not actually the case.
Contributor
Author
There was a problem hiding this comment.
Now we return UnresolvedDelegationCallee when there is only one visited node, which means that we failed to find the callee, in other cases we return CycleInDelegationSignatureResolution error, we may try to collect all spans of this cycle for better message, but I am not sure If we need it.
petrochenkov
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for recursive delegations and is a part of the delegation feature #118212.
r? @petrochenkov