mir_build: Rename TestCase to TestableCase
#150051
Open
+64
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in match lowering cc @Nadrieril |
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Nadrieril
reviewed
Dec 16, 2025
Comment on lines
-1264
to
+1267
| enum TestCase<'tcx> { | ||
| enum TestableCase<'tcx> { |
Member
There was a problem hiding this comment.
For me TestableCase is more confusing than TestCase. I would prefer TestOutcome for example
Member
|
r? me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #149946, this is another renaming of something I've always found confusing.
When lowering match conditions, there is a subtle distinction between the kind of test being performed (on a scrutinee place), the possible outcomes of that test, and the different “cases” (corresponding to pattern nodes) that the test is distinguishing. Cases imply a particular preferred test, but once a test is chosen it can also interact with other cases as well.
I have often mixed up
TestKindandTestCase, since the names are so similar, and they share several variant names. Therefore, this PR renamesTestCasetoTestableCase, to emphasise that these are the things selected by whatever test is being performed.There should be no change to compiler behaviour.