miri: add miri_spin_loop to make hint::spin_loop work consistently
#150088
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
riscv-pause-miri
branch
from
4fbc49f to
7f022df
Compare
RalfJung
requested changes
Dec 17, 2025
| this.write_int(if success { 0 } else { needed_size }, dest)?; | ||
| } | ||
| // Hint that a loop is spinning indefinitely. | ||
| "miri_spin_loop" => { |
Member
There was a problem hiding this comment.
Please also add this function in tests/utils/miri_extern.rs inside Miri, with a suitable doc comment.
| } | ||
| // Hint that a loop is spinning indefinitely. | ||
| "miri_spin_loop" => { | ||
| // To maximize the chance of finding actual bugs, try to find another thread to |
Member
There was a problem hiding this comment.
Suggested change
| // To maximize the chance of finding actual bugs, try to find another thread to | |
| let [] = this.check_shim_sig_lenient(abi, CanonAbi::Rust, link_name, args)?; | |
| // To maximize the chance of finding actual bugs, try to find another thread to |
Comment on lines
+278
to
+279
| // consistent behavior across targets, this custom function is used. To maximize the | ||
| // likelihood of finding actual issues, it will attempt to find another thread to run. |
Member
There was a problem hiding this comment.
Suggested change
| // consistent behavior across targets, this custom function is used. To maximize the | |
| // likelihood of finding actual issues, it will attempt to find another thread to run. | |
| // consistent behavior across targets, this custom function is used. |
What that function does is Miri's choice and maybe we'll change it in the future.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #150050
Always use the same implementation when running miri (regardless of target, for consistency). This implementation yields the current thread to try find actual bugs.
r? RalfJung