Skip to content

Conversation

@Darksonn
Copy link
Contributor

This uses the newly created tracking issue #150112.

Please see #68015 (comment) for motivation.

r? @jackh726

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 17, 2025
@rust-log-analyzer

This comment has been minimized.

@Darksonn Darksonn force-pushed the pin-coerce-unsized-to-150112 branch from 545df8f to 78f52c1 Compare December 17, 2025 20:28
@rustbot rustbot added the O-SGX Target: SGX label Dec 17, 2025
@jackh726
Copy link
Member

Hmm, so should the impls be unstable under the same feature? It's super weird because

  1. Unstable attrs on impls don't currently do anything
  2. These impls aren't actually unstable, because you can use these on stable through stable types.

I'm going to go ahead and say yes, since it just doesn't actually matter in practice

Thanks :)

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 17, 2025

📌 Commit 78f52c1 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025
@Darksonn
Copy link
Contributor Author

Yeah I don't know 🤷‍♀️

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 17, 2025
…112, r=jackh726

Update tracking issue for PinCoerceUnsized

This uses the newly created tracking issue rust-lang#150112.

Please see rust-lang#68015 (comment) for motivation.

r? `@jackh726`
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 17, 2025
…112, r=jackh726

Update tracking issue for PinCoerceUnsized

This uses the newly created tracking issue rust-lang#150112.

Please see rust-lang#68015 (comment) for motivation.

r? ``@jackh726``
@BoxyUwU
Copy link
Member

BoxyUwU commented Dec 17, 2025

Unstable attrs on impls don't currently do anything

if you do want to make them actually unstable we have the ability to mark impls as unstable. But given these impls are actually usable on stable that would probably not work

bors added a commit that referenced this pull request Dec 17, 2025
…uwer

Rollup of 4 pull requests

Successful merges:

 - #149922 (Tidying up tests/ui/issues 14 tests [5/N])
 - #150095 (Port `#[rustc_no_implicit_autorefs]`, `#[rustc_lint_opt_ty]`, and `#[rustc_lint_query_instability]` attributes to be parsed)
 - #150099 ([rustdoc] Fix invalid handling of field followed by negated macro call)
 - #150113 (Update tracking issue for PinCoerceUnsized)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants