Add methods to split off array chunks from slices #150117
Open
+200
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the slice methods described in my ACP rust-lang/libs-team#543:
The only difference from my original ACP post was that I put the
first/lastbeforechunkin the name instead of after it. My default intuition when I wrote that ACP was to have the names all appear next to each other alphabetically, but as I was implementing it I checked for similar-looking functions, and I found thatsplit_first_chunkand related methods (which are basically these methods but without the in-place modification ofself) do the other order and I decided it would be better to match how the other functions are named.This is my first PR into rust itself, so I did my best to figure out the norms (both for the process around making a PR and the code I put in the PR) and follow them, but I probably got some stuff wrong so I'm sorry in advance for whatever I got wrong.