Rollup of 3 pull requests #150147

matthiaskrgr · 2025-12-19T08:25:26Z

Successful merges:

cg_llvm: More preparation for moving FFI bindings to rustc_llvm #147430 (cg_llvm: More preparation for moving FFI bindings to rustc_llvm)
Add regression test for #120189 #149815 (Add regression test for for loop in closure is not unrolled and not vectorlized correctly #120189)
Port #[rustc_lint_untracked_query_information] and #[rustc_lint_diagnostics] to using attribute parsers #150127 (Port #[rustc_lint_untracked_query_information] and #[rustc_lint_diagnostics] to using attribute parsers)

r? @ghost
@rustbot modify labels: rollup

cg_llvm: More preparation for moving FFI bindings to `rustc_llvm` - Sequel to rust-lang#147327 - Motivated by rust-lang#142897 --- This is another batch of adjustments to code that would otherwise interfere with moving FFI bindings out of `rustc_codegen_llvm` and into `rustc_llvm`.

…test, r=chenyukang Add regression test for rust-lang#120189 This PR adds regression tests for rust-lang#120189. I added tests to verify vectorization of loops inside closures.

…_query_information, r=JonathanBrouwer Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers r? ``@JonathanBrouwer``

matthiaskrgr · 2025-12-19T08:25:41Z

@bors r+ rollup=never p=5

bors · 2025-12-19T08:25:44Z

📌 Commit 0e623bb has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-12-19T08:29:49Z

⌛ Testing commit 0e623bb with merge d7b1d36...

Rollup of 3 pull requests Successful merges: - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`) - #149815 (Add regression test for #120189) - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-12-19T08:34:18Z

⌛ Testing commit 0e623bb with merge 0f0d850...

bors · 2025-12-19T11:44:03Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 0f0d850 to main...

rust-timer · 2025-12-19T11:44:57Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147430	cg_llvm: More preparation for moving FFI bindings to `rustc…	`fe5068825f7dc990da97afa52ad16ca74d3d630d` (link)
#149815	Add regression test for #120189	`8032001cdb370cd450b6108f4414dbef76e19d15` (link)
#150127	Port `#[rustc_lint_untracked_query_information]` and `#[rus…	`05907287844b3e6e596e2eaa25764c780d0828d3` (link)

previous master: 07a5b02a2d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-12-19T11:47:33Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 07a5b02 (parent) -> 0f0d850 (this PR)

Test differences

Show 429 test diffs

Stage 0

errors::verify_passes_abi_of_63: pass -> [missing] (J1)
errors::verify_passes_attr_application_enum_76: pass -> [missing] (J1)
errors::verify_passes_attr_application_struct_76: [missing] -> pass (J1)
errors::verify_passes_attr_application_struct_77: pass -> [missing] (J1)
errors::verify_passes_attr_crate_level_96: [missing] -> pass (J1)
errors::verify_passes_collapse_debuginfo_45: [missing] -> pass (J1)
errors::verify_passes_debug_visualizer_unreadable_36: [missing] -> pass (J1)
errors::verify_passes_deprecated_attribute_81: pass -> [missing] (J1)
errors::verify_passes_doc_inline_only_use_21: pass -> [missing] (J1)
errors::verify_passes_doc_keyword_attribute_empty_mod_14: [missing] -> pass (J1)
errors::verify_passes_doc_keyword_only_impl_17: [missing] -> pass (J1)
errors::verify_passes_doc_masked_not_extern_crate_self_23: pass -> [missing] (J1)
errors::verify_passes_doc_masked_only_extern_crate_21: [missing] -> pass (J1)
errors::verify_passes_doc_search_unbox_invalid_19: pass -> [missing] (J1)
errors::verify_passes_eii_impl_not_function_111: [missing] -> pass (J1)
errors::verify_passes_eii_without_impl_114: pass -> [missing] (J1)
errors::verify_passes_extern_main_69: [missing] -> pass (J1)
errors::verify_passes_feature_previously_declared_67: [missing] -> pass (J1)
errors::verify_passes_feature_stable_twice_67: pass -> [missing] (J1)
errors::verify_passes_inline_ignored_for_exported_74: pass -> [missing] (J1)
errors::verify_passes_lang_item_fn_with_track_caller_52: pass -> [missing] (J1)
errors::verify_passes_layout_align_58: pass -> [missing] (J1)
errors::verify_passes_layout_homogeneous_aggregate_60: pass -> [missing] (J1)
errors::verify_passes_layout_of_61: pass -> [missing] (J1)
errors::verify_passes_macro_only_attribute_35: [missing] -> pass (J1)
errors::verify_passes_missing_const_stab_attr_85: [missing] -> pass (J1)
errors::verify_passes_missing_panic_handler_48: [missing] -> pass (J1)
errors::verify_passes_missing_stability_attr_85: pass -> [missing] (J1)
errors::verify_passes_multiple_rustc_main_69: pass -> [missing] (J1)
errors::verify_passes_object_lifetime_err_74: [missing] -> pass (J1)
errors::verify_passes_panic_unwind_without_std_50: pass -> [missing] (J1)
errors::verify_passes_repr_conflicting_33: pass -> [missing] (J1)
errors::verify_passes_repr_conflicting_35: pass -> [missing] (J1)
errors::verify_passes_rustc_dirty_clean_31: [missing] -> pass (J1)
errors::verify_passes_rustc_dirty_clean_32: pass -> [missing] (J1)
errors::verify_passes_rustc_force_inline_coro_40: pass -> [missing] (J1)
errors::verify_passes_sanitize_attribute_not_allowed_98: pass -> [missing] (J1)
errors::verify_passes_transparent_incompatible_79: [missing] -> pass (J1)
errors::verify_passes_unexportable_adt_with_private_fields_106: [missing] -> pass (J1)
errors::verify_passes_unexportable_type_in_interface_104: [missing] -> pass (J1)
errors::verify_passes_unexportable_type_repr_103: [missing] -> pass (J1)
errors::verify_passes_unknown_feature_alias_87: [missing] -> pass (J1)
errors::verify_passes_unstable_attr_for_already_stable_feature_83: [missing] -> pass (J1)
errors::verify_passes_unsupported_attributes_in_where_100: pass -> [missing] (J1)
errors::verify_passes_unused_multiple_45: pass -> [missing] (J1)
errors::verify_passes_useless_stability_81: [missing] -> pass (J1)

Stage 1

errors::verify_passes_attr_application_struct_union_77: [missing] -> pass (J0)
errors::verify_passes_collapse_debuginfo_46: pass -> [missing] (J0)
errors::verify_passes_const_stable_not_stable_91: [missing] -> pass (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_110: [missing] -> pass (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_111: pass -> [missing] (J0)
errors::verify_passes_deprecated_attribute_80: [missing] -> pass (J0)
errors::verify_passes_doc_alias_not_an_alias_13: [missing] -> pass (J0)
errors::verify_passes_doc_attr_not_crate_level_23: [missing] -> pass (J0)
errors::verify_passes_doc_inline_conflict_19: [missing] -> pass (J0)
errors::verify_passes_doc_keyword_attribute_empty_mod_14: [missing] -> pass (J0)
errors::verify_passes_doc_masked_only_extern_crate_21: [missing] -> pass (J0)
errors::verify_passes_duplicate_diagnostic_item_in_crate_55: [missing] -> pass (J0)
errors::verify_passes_duplicate_eii_impls_115: pass -> [missing] (J0)
errors::verify_passes_eii_fn_with_track_caller_113: pass -> [missing] (J0)
errors::verify_passes_extern_main_70: pass -> [missing] (J0)
errors::verify_passes_has_incoherent_inherent_impl_24: [missing] -> pass (J0)
errors::verify_passes_has_incoherent_inherent_impl_25: pass -> [missing] (J0)
errors::verify_passes_incorrect_target_71: pass -> [missing] (J0)
errors::verify_passes_ineffective_unstable_impl_95: [missing] -> pass (J0)
errors::verify_passes_ineffective_unstable_impl_96: pass -> [missing] (J0)
errors::verify_passes_inline_ignored_for_exported_73: [missing] -> pass (J0)
errors::verify_passes_layout_homogeneous_aggregate_60: pass -> [missing] (J0)
errors::verify_passes_layout_invalid_attribute_61: [missing] -> pass (J0)
errors::verify_passes_layout_invalid_attribute_62: pass -> [missing] (J0)
errors::verify_passes_layout_of_61: pass -> [missing] (J0)
errors::verify_passes_may_dangle_42: [missing] -> pass (J0)
errors::verify_passes_missing_const_err_90: [missing] -> pass (J0)
errors::verify_passes_missing_const_stab_attr_86: pass -> [missing] (J0)
errors::verify_passes_missing_lang_item_50: [missing] -> pass (J0)
errors::verify_passes_missing_lang_item_51: pass -> [missing] (J0)
errors::verify_passes_multiple_rustc_main_69: pass -> [missing] (J0)
errors::verify_passes_repr_align_should_be_align_static_108: [missing] -> pass (J0)
errors::verify_passes_repr_conflicting_35: pass -> [missing] (J0)
errors::verify_passes_rustc_allow_const_fn_unstable_37: [missing] -> pass (J0)
errors::verify_passes_rustc_allow_const_fn_unstable_38: pass -> [missing] (J0)
errors::verify_passes_rustc_const_stable_indirect_pairing_98: [missing] -> pass (J0)
errors::verify_passes_rustc_const_stable_indirect_pairing_99: pass -> [missing] (J0)
errors::verify_passes_rustc_force_inline_coro_40: pass -> [missing] (J0)
errors::verify_passes_rustc_legacy_const_generics_index_exceed_30: [missing] -> pass (J0)
errors::verify_passes_rustc_legacy_const_generics_index_exceed_31: pass -> [missing] (J0)
errors::verify_passes_rustc_pub_transparent_38: [missing] -> pass (J0)
errors::verify_passes_sanitize_attribute_not_allowed_98: pass -> [missing] (J0)
errors::verify_passes_trait_impl_const_stable_86: [missing] -> pass (J0)
errors::verify_passes_unexportable_adt_with_private_fields_106: [missing] -> pass (J0)
errors::verify_passes_unexportable_priv_item_106: pass -> [missing] (J0)
errors::verify_passes_unexportable_type_in_interface_104: [missing] -> pass (J0)
errors::verify_passes_unexportable_type_repr_104: pass -> [missing] (J0)
errors::verify_passes_unknown_external_lang_item_47: [missing] -> pass (J0)
errors::verify_passes_unknown_feature_alias_88: pass -> [missing] (J0)
errors::verify_passes_unknown_lang_item_55: pass -> [missing] (J0)
errors::verify_passes_unnecessary_partial_stable_feature_95: pass -> [missing] (J0)
errors::verify_passes_unnecessary_stable_feature_94: pass -> [missing] (J0)
errors::verify_passes_unused_duplicate_44: pass -> [missing] (J0)
errors::verify_passes_useless_stability_82: pass -> [missing] (J0)

(and 329 additional test diffs)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0f0d850e9146f53b16fb1c6a56ed2f821962ff94 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4390.6s -> 3558.8s (-18.9%)
x86_64-gnu-llvm-21-1: 3926.6s -> 4565.4s (+16.3%)
dist-aarch64-apple: 7296.0s -> 8173.8s (+12.0%)
dist-i586-gnu-i586-i686-musl: 4924.2s -> 5510.0s (+11.9%)
tidy: 168.1s -> 148.8s (-11.5%)
dist-various-1: 3664.5s -> 4007.4s (+9.4%)
x86_64-gnu: 7574.0s -> 8251.0s (+8.9%)
dist-x86_64-llvm-mingw: 6480.6s -> 7041.5s (+8.7%)
aarch64-gnu-llvm-20-2: 2991.7s -> 2738.6s (-8.5%)
x86_64-msvc-ext1: 7133.1s -> 7703.9s (+8.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-19T12:26:17Z

Finished benchmarking commit (0f0d850): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.5%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.5%	[2.8%, 4.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	1.5%	[-2.5%, 4.1%]	3

Cycles

Results (secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-4.7%, -2.9%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.939s -> 479.055s (-0.60%)
Artifact size: 390.52 MiB -> 390.50 MiB (-0.01%)

is57primenumber and others added 8 commits December 9, 2025 23:02

Add regression test for closure loop vectorization

2bda671

Port #[rustc_lint_untracked_query_information] to attribute parser

5277241

Port #[rustc_lint_diagnostics] to attribute parser

44cfed7

Remove inherent methods from llvm::TypeKind

c2f8ee9

Move DIBuilderBox out of ffi.rs

735a980

Rollup merge of rust-lang#149815 - is57primenumber:add-slp-vectorize-…

eb0f575

…test, r=chenyukang Add regression test for rust-lang#120189 This PR adds regression tests for rust-lang#120189. I added tests to verify vectorization of loops inside closures.

Rollup merge of rust-lang#150127 - Bryntet:parse_rustc_lint_untracked…

0e623bb

…_query_information, r=JonathanBrouwer Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers r? ``@JonathanBrouwer``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 19, 2025

bors merged commit 0f0d850 into rust-lang:main Dec 19, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 3 pull requests #150147

Rollup of 3 pull requests #150147

Uh oh!

matthiaskrgr commented Dec 19, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Stage 0

Stage 1

Uh oh!

rust-timer commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Rollup of 3 pull requests #150147

Rollup of 3 pull requests #150147

Uh oh!

Conversation

matthiaskrgr commented Dec 19, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

bors commented Dec 19, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Test differences

Stage 0

Stage 1

Job duration changes

Uh oh!

rust-timer commented Dec 19, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

matthiaskrgr commented Dec 19, 2025 •

edited by rustbot

Loading