Split eii macro expansion code #150159
Open
Split eii macro expansion code #150159
+238
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
split-eii-macro
branch
from
73e9987 to
82058c8
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
approved these changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
@jdonszelmann r=me after fixing tidy and after possible addressing my comment
jdonszelmann
force-pushed
the
split-eii-macro
branch
from
82058c8 to
1a5f0c6
Compare
jdonszelmann
force-pushed
the
split-eii-macro
branch
from
1a5f0c6 to
6608f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? jonathanbrouwer (since you did the last one too, should be quite trivial)
While investigating #149980 I decided this code deserved some splitting :)