Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Dec 19, 2025

This PR fixes the const_item_interior_mutations lint so we don't lint on interior mutable const item coming from derefs.

Fixes #150157

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Urgau Urgau added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 19, 2025
@Kivooeo
Copy link
Member

Kivooeo commented Dec 19, 2025

r? me

@rustbot rustbot assigned Kivooeo and unassigned madsmtm Dec 19, 2025
@Kivooeo
Copy link
Member

Kivooeo commented Dec 19, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 19, 2025
Don't lint on interior mutable `const` item coming from derefs
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2025
@rust-bors
Copy link

rust-bors bot commented Dec 19, 2025

☀️ Try build successful (CI)
Build commit: 2ac72c4 (2ac72c46c0316e5594ee1deb47ea790d69c07819, parent: b889870082dd0b0e3594bbfbebb4545d54710829)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2ac72c4): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
-2.6% [-2.8%, -2.3%] 2
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) -2.6% [-2.8%, -2.3%] 2

Cycles

Results (primary 4.2%, secondary 5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.2% [2.0%, 15.3%] 22
Regressions ❌
(secondary)
5.7% [1.9%, 20.8%] 21
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.2% [2.0%, 15.3%] 22

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.396s -> 479.351s (-0.01%)
Artifact size: 390.52 MiB -> 390.57 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2025
@Urgau Urgau force-pushed the const-item-lint-150157 branch from 51df3b8 to 2581c25 Compare December 19, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

const_item_interior_mutations false-positive

5 participants