Skip to content

[beta] backports #150214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cuviper wants to merge 3 commits into
base: beta
Choose a base branch
from
Open

[beta] backports #150214

cuviper wants to merge 3 commits into from

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Dec 20, 2025 •
edited by rustbot
Loading

Kivooeo and others added 3 commits December 20, 2025 13:54
@Kivooeo @cuviper
add check for uninhabited types along side never
3f4f07f 
(cherry picked from commit 2a2da78)
@nikic @cuviper
Update to LLVM 21.1.8
834ced4 
(cherry picked from commit f33abb1)
@Amanieu @cuviper
Revert rust-lang#148937 (Remove initialized-bytes tracking from `Borr…
4bc6d75 
…owedBuf` and `BorrowedCursor`)

This caused several performance regressions because of existing code
which uses `Read::read` and therefore requires full buffer
initialization. This is particularly a problem when the same buffer is
re-used for multiple read calls since this means it needs to be fully
re-initialized each time.

There is still some benefit to landing the API changes, but we will have
to add private APIs so that the existing infrastructure can
track and avoid redundant initialization.

(cherry picked from commit 4b07875)
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-SGX Target: SGX O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

    If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@Kivooeo
Copy link
Member

Kivooeo commented Dec 20, 2025 •
edited
Loading

can you please also add this one #150056, this is a follow up on #149664

so i feel like it would be nice if we could backbort them together

or replace #149664 with #150056, since latter one is fixes perf and self-sufficient

@cuviper
Copy link
Member Author

cuviper commented Dec 20, 2025

@Kivooeo, we (release team) do these backports mechanically based on the owning team's approvals, and that one doesn't have beta-accepted yet. Looks good so far in the zulip thread though!

@Kivooeo
Copy link
Member

Kivooeo commented Dec 20, 2025 •
edited
Loading

oh, it still wasn't been approved on a backport, yeah, i see it makes sense

i just got concerned in a moment that less performant version will get into the beta and the one with better performance is not

but now i feel like we still have a bunch of time, and it shouldnt be a problem, right? like, the second version will anyway gets in beta

@cuviper
Copy link
Member Author

cuviper commented Dec 20, 2025

Yes, we're still quite early in the beta phase -- 1.93 release isn't until January 22.

@cuviper
Copy link
Member Author

cuviper commented Dec 20, 2025

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Dec 20, 2025

📌 Commit 4bc6d75 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-SGX Target: SGX O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cuviper @rustbot @Kivooeo @bors @nikic @Amanieu