Skip to content

rustdoc: upgrade to stringdex 0.0.4 #150217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
notriddle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rustdoc: upgrade to stringdex 0.0.4 #150217

notriddle wants to merge 1 commit into from
+119 −26

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented Dec 21, 2025

  • code cleanup
  • smaller encoding for runs
  • fast path for the common encoding case

@notriddle
rustdoc: upgrade to stringdex 0.0.4
08c396b 
- code cleanup
- smaller encoding for runs
- fast path for the common encoding case
@notriddle notriddle requested a review from yotamofek December 21, 2025 06:47
@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle notriddle mentioned this pull request Dec 21, 2025
Closed
@notriddle
Copy link
Contributor Author

notriddle commented Dec 21, 2025

Performance tested in: #149887

@yotamofek
Copy link
Contributor

yotamofek commented Dec 21, 2025

Amazing work!

@bors rollup=never
since this affects perf

r=me once (if) CI is green, unless you'd rather wait for @GuillaumeGomez 's review too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yotamofek yotamofek Awaiting requested review from yotamofek

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@notriddle @rustbot @yotamofek @GuillaumeGomez