Skip to content

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Dec 22, 2025

Stumbled upon a weird (bug ?) behaviour while making this PR

it seems like it is possible to reach check_attr.rs checks without the attribute allowed target checks having already been finished, I added a comment about how to reproduce this in check_attr.rs

otherwise good to note is that a bunch of code was moved from compiler/rustc_hir_analysis/src/collect.rs to check_attr.rs

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2025

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 22, 2025
@rust-log-analyzer

This comment has been minimized.

@Bryntet Bryntet force-pushed the parse_rustc_must_impl branch from deda7ae to 12368ec Compare December 22, 2025 00:59
@Bryntet Bryntet force-pushed the parse_rustc_must_impl branch from 12368ec to c94487d Compare December 22, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants