Skip to content

replace match on unchecked_sub with unwrap_or_default #150262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hkBst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace match on unchecked_sub with unwrap_or_default #150262

hkBst wants to merge 1 commit into from
+1 −4

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Dec 22, 2025 •
edited
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned Kivooeo and unassigned scottmcm Dec 22, 2025
Kivooeo
Kivooeo approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good change to me, but unfortunately I can't r+ it since this is a library change

r? scottmcm

View changes since this review

@rustbot rustbot assigned scottmcm and unassigned Kivooeo Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@scottmcm scottmcm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hkBst @rustbot @Kivooeo @scottmcm