Skip to content

Conversation

@notgull
Copy link
Contributor

@notgull notgull commented Dec 23, 2025

Fixes time.rs by updating the MIN and MAX structs appropraitely.

Fixes #150294

@rustbot rustbot added O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Fixes time.rs by updating the MIN and MAX structs appropriately.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Contributor Author

notgull commented Dec 23, 2025

Looks like this was done by accident as part of #148825

@joboet
Copy link
Member

joboet commented Dec 23, 2025

Looks that way...
@bors r+ rollup
r? joboet

@bors
Copy link
Collaborator

bors commented Dec 23, 2025

📌 Commit 2c0f14c has been approved by joboet

It is now in the queue for this repository.

@rustbot rustbot assigned joboet and unassigned ChrisDenton Dec 23, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 23, 2025
Fix compilation error in hermit-abi time.rs

Fixes time.rs by updating the MIN and MAX structs appropraitely.

Fixes rust-lang#150294
bors added a commit that referenced this pull request Dec 23, 2025
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150205 (compiletest: Add `LineNumber` newtype to avoid `+1` magic here and there)
 - #150295 (Fix compilation error in hermit-abi time.rs)
 - #150301 (std: remove unsupported pipe module from VEXos pal)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 23, 2025
…uwer

Rollup of 6 pull requests

Successful merges:

 - #150130 (Support syntax for one-line trait reuse)
 - #150205 (compiletest: Add `LineNumber` newtype to avoid `+1` magic here and there)
 - #150282 (move a ui test to coretests unit test)
 - #150295 (Fix compilation error in hermit-abi time.rs)
 - #150301 (std: remove unsupported pipe module from VEXos pal)
 - #150303 (`target_features::Stability`: tweak docs of `requires_nightly()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ca7f0d into rust-lang:main Dec 23, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 23, 2025
rust-timer added a commit that referenced this pull request Dec 23, 2025
Rollup merge of #150295 - forkgull:notgull/hermit-fix, r=joboet

Fix compilation error in hermit-abi time.rs

Fixes time.rs by updating the MIN and MAX structs appropraitely.

Fixes #150294
@notgull notgull deleted the notgull/hermit-fix branch December 23, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-hermit Operating System: Hermit S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pal::hermit::time::SystemTime is not compiling in libstd for Hermit ABI

5 participants