Skip to content

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Jan 5, 2026

Subtree update of rust-analyzer to rust-lang/rust-analyzer@6a1246b.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost

A4-Tacks and others added 30 commits December 29, 2025 06:45
Example
---
```rust
enum Foo {
    Num(i32)
}

impl Foo {
    fn try_into_num(self) -> Result<i32, Self> {
        if let Self::Num(v) = self {
            Ok(v)
        } else {
            Err(self)
        }
    }
}
fn handle(foo: Foo) {
    foo.try_into_num().$0
}
```

**Before this PR**

```rust
fn handle(foo: Foo) {
    if let Ok(${1:try_into_num}) = foo.try_into_num() {
        $0
    }
}
```

**After this PR**

```rust
fn handle(foo: Foo) {
    if let Ok(${1:num}) = foo.try_into_num() {
        $0
    }
}
```
Allow finding references from doc comments
Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.14.0...v6.14.1)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.14.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…-into

Add useless prefix `try_into_` for suggest_name
…yarn/editors/code/qs-6.14.1

Bump qs from 6.14.0 to 6.14.1 in /editors/code
To reduce the amount of re-allocating the hashtables which can be expensive given the need to re-hash
Pre-allocate intern storages with 64kb of data / 1024 elements
Remove unnecessary `ConstLiteralRef` enum
…nlay-hint-location-links

feat: Add location links for generic parameter type hints
internal: Reduce `impl_signature` query dependencies in method resolution
…e-proc-macro-bidirectional-flow

proc-macro-srv: support file and local_file via bidirectional callbacks
perf: Only compute lang items for `#![feature(lang_items)]` crates
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Jan 5, 2026
@lnicola
Copy link
Member Author

lnicola commented Jan 5, 2026

@bors r+ p=1 rollup=always

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

📌 Commit 8ddb153 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 5, 2026
`rust-analyzer` subtree update

Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@6a1246b.

Created using https://github.com/rust-lang/josh-sync.

r? `@ghost`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2026
`rust-analyzer` subtree update

Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@6a1246b.

Created using https://github.com/rust-lang/josh-sync.

r? ``@ghost``
bors added a commit that referenced this pull request Jan 5, 2026
Rollup of 3 pull requests

Successful merges:

 - #150412 (use PIDFD_GET_INFO ioctl when available)
 - #150668 (Unix implementation for stdio set/take/replace)
 - #150702 (`rust-analyzer` subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Jan 5, 2026

⌛ Testing commit 8ddb153 with merge 7c04f5d...

@bors
Copy link
Collaborator

bors commented Jan 6, 2026

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 7c04f5d to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2026
@bors bors merged commit 7c04f5d into rust-lang:main Jan 6, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4fa80a5 (parent) -> 7c04f5d (this PR)

Test differences

Show 12 test diffs

Stage 0

  • handlers::trait_impl_missing_assoc_item::tests::no_false_positive_on_specialization: [missing] -> pass (J1)
  • inlay_hints::bind_pat::tests::const_param_inlay_hint_has_location_link: [missing] -> pass (J1)
  • inlay_hints::bind_pat::tests::lifetime_param_inlay_hint_has_location_link: [missing] -> pass (J1)
  • inlay_hints::bind_pat::tests::type_param_inlay_hint_has_location_link: [missing] -> pass (J1)
  • references::tests::test_find_all_refs_in_comments: [missing] -> pass (J1)

Stage 1

  • handlers::trait_impl_missing_assoc_item::tests::no_false_positive_on_specialization: [missing] -> pass (J0)
  • inlay_hints::bind_pat::tests::const_param_inlay_hint_has_location_link: [missing] -> pass (J0)
  • inlay_hints::bind_pat::tests::lifetime_param_inlay_hint_has_location_link: [missing] -> pass (J0)
  • inlay_hints::bind_pat::tests::type_param_inlay_hint_has_location_link: [missing] -> pass (J0)
  • references::tests::test_find_all_refs_in_comments: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7c04f5d216b5dcfff0a55fc20327a1c519004699 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 12402.9s -> 8059.4s (-35.0%)
  2. dist-apple-various: 4625.0s -> 3728.6s (-19.4%)
  3. x86_64-gnu-tools: 3660.9s -> 3000.8s (-18.0%)
  4. pr-check-1: 1839.6s -> 1509.4s (-18.0%)
  5. x86_64-gnu-debug: 7599.1s -> 6265.8s (-17.5%)
  6. aarch64-gnu: 8157.2s -> 7036.6s (-13.7%)
  7. i686-gnu-2: 6062.7s -> 5238.1s (-13.6%)
  8. x86_64-gnu-gcc: 3753.5s -> 3244.6s (-13.6%)
  9. i686-gnu-nopt-1: 8600.9s -> 7483.0s (-13.0%)
  10. dist-ohos-x86_64: 4242.0s -> 4721.1s (+11.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7c04f5d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.7%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Cycles

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.6%, -2.1%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.645s -> 475.09s (0.52%)
Artifact size: 390.76 MiB -> 390.73 MiB (-0.01%)

@lnicola lnicola deleted the sync-from-ra branch January 6, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.