fix: more descriptive error message for enum to integer #151122
+51
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
|
|
||
| fn main() { | ||
| let priority = &Priority::Normal; | ||
| let priority = priority as u8; //~ ERROR casting `&Priority` as `u8` is invalid |
Member
There was a problem hiding this comment.
It might be a good idea to check the HELP message as well.
like
Suggested change
| let priority = priority as u8; //~ ERROR casting `&Priority` as `u8` is invalid | |
| let priority = priority as u8; //~ ERROR casting `&Priority` as `u8` is invalid | |
| //~| HELP: dereference the expression |
Author
There was a problem hiding this comment.
It might be a good idea to check the HELP message as well. like
Ty! will add this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #151116
A more descriptive error message when casting an enum to an Integer. Please review issue linked above. Here is a screenshot of the casting tests passing.