Skip to content

Rollup of 3 pull requests #151506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 6 commits into from
Jan 23, 2026
Merged

Rollup of 3 pull requests #151506

rust-bors merged 6 commits into from
Jan 23, 2026

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jan 22, 2026

Successful merges:

r? @ghost

Create a similar rollup

WhyNovaa and others added 6 commits January 21, 2026 19:00
@WhyNovaa
diagnostics: suggest deriving Default for enums
2f75c54
@bodhisilberling
Fix typo: 'recieve' -> 'receive' in lldb-visualizers.md
8aa5d5a
@enthropy7
Fix ICE when using zero-length SIMD type in extern static
b970366 
Previously, using a zero-length SIMD type in an extern static would
cause an internal compiler error. Now it properly emits a diagnostic
error instead of panicking.
@JonathanBrouwer
Rollup merge of rust-lang#151412 - WhyNovaa:diagnostics-impl-enum-fix…
a2c53d6 
…, r=lcnr

diagnostics: suggest deriving Default for enums

Fixing outdated code: now we can derive Default for enums

r? @lcnr
@JonathanBrouwer
Rollup merge of rust-lang#151495 - enthropy7:fix-simd-zero-length-ext…
cbab2f0 
…ern-static, r=JonathanBrouwer

Fix ICE when using zero-length SIMD type in extern static

before my fix using a zero-length SIMD type in an extern static would cause an internal compiler error. now it properly shows a diagnostic error instead of panicking. it was because `LayoutError::InvalidSimd` wasn't handled in `check_static_inhabited` and fell through to a generic `delayed_bug`.

i added handling for `InvalidSimd` in `check_static_inhabited` (similar to `SizeOverflow`): when a SIMD type has an invalid layout, we call `emit_err` with `Spanned` to emit a normal error instead of an ICE. compiler now emits a clear error `"the SIMD type Simd<u8, 0> has zero elements"` with the correct span on the type, matching expected compiler behavior.

fixes rust-lang#151451
@JonathanBrouwer
Rollup merge of rust-lang#151497 - bodhisilberling-2027:fix-typo-reci…
04246de 
…eve-receive, r=tshepang

Fix typo: 'recieve' -> 'receive' in lldb-visualizers.md
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Jan 22, 2026
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jan 22, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 22, 2026

📌 Commit 04246de has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 23, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 16m 43s
Pushing d10ac47 to main...

@rust-bors rust-bors bot merged commit d10ac47 into rust-lang:main Jan 23, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 23, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 23, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#151412 diagnostics: suggest deriving Default for enums be5b7ec7f2e916a22c55dd28be0319169032c33d (link)
#151495 Fix ICE when using zero-length SIMD type in extern static cd5f9474ecd00a9358be3d9ec3dae9a7b76ff37f (link)
#151497 Fix typo: 'recieve' -> 'receive' in lldb-visualizers.md 03dfaf5f6a333df93e768e4243ac59dd0d834df0 (link)

previous master: 39052daf93

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 39052da (parent) -> d10ac47 (this PR)

Test differences

Show 8 test diffs

Stage 1

  • [ui] tests/ui/simd/extern-static-zero-length.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/suggest-derive-default-for-enums.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/simd/extern-static-zero-length.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/suggest-derive-default-for-enums.rs: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d10ac47c20152feb5e99b1c35a2e6830f77c66dc --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6757.8s -> 8829.5s (+30.7%)
  2. dist-x86_64-apple: 7979.1s -> 8727.6s (+9.4%)
  3. dist-various-1: 4404.7s -> 3993.8s (-9.3%)
  4. i686-gnu-nopt-1: 6824.2s -> 7440.4s (+9.0%)
  5. dist-x86_64-mingw: 9663.5s -> 8798.6s (-9.0%)
  6. x86_64-gnu-gcc: 3754.1s -> 3475.3s (-7.4%)
  7. dist-aarch64-llvm-mingw: 5877.6s -> 6304.6s (+7.3%)
  8. dist-apple-various: 4580.6s -> 4273.4s (-6.7%)
  9. dist-x86_64-illumos: 5684.0s -> 6039.4s (+6.3%)
  10. test-various: 6759.3s -> 6337.1s (-6.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Jan 23, 2026
Open
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 23, 2026

Finished benchmarking commit (d10ac47): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.8%, secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)		 -3.9% [-5.8%, -2.0%] 2
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.794s -> 473.42s (-0.08%)
Artifact size: 383.23 MiB -> 383.22 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @rust-timer @rustbot @WhyNovaa @bodhisilberling @enthropy7