compiletest: Ignore rust.optimize-tests for assembly and codegen tests
#151585
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Zalathar
changed the title
rust.optimize-tests for assembly and codegen testsrust.optimize-tests for assembly and codegen tests
Contributor
|
discussion on zulip: #t-compiler > LLVM tests with no optimizations |
| .props | ||
| .compile_flags | ||
| .iter() | ||
| .any(|arg| arg == "-O" || arg.contains("opt-level")) |
Member
There was a problem hiding this comment.
Why do we need this check against compile-flags here, but not below? Maybe this can be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are inherently sensitive to optimization level, so it's silly to have new tests mysteriously fail in no-opt CI jobs just because they didn't specify an explicit opt-level.
Fixes #151580.