Remove some unnecessary try-related type annotations
#151887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I left a few, like
```rust
let result: Result<_, ModError<'_>> = try {
```
where it felt like seeing it might still be useful for the reader.
Feel free to push back on any of these changes if you think seeing the type would be better.
Collaborator
|
Some changes occurred in need_type_info.rs cc @lcnr |
rustbot
added
S-waiting-on-review
Collaborator
scottmcm
commented
Jan 31, 2026
| } | ||
| } | ||
| } | ||
| .unwrap_or_default() |
Member
Author
There was a problem hiding this comment.
annot: the whitespace changed here, so you might want the ignore whitespace diff for this function.
chenyukang
reviewed
Jan 31, 2026
|
|
||
| let generics = tcx.generics_of(def_id); | ||
| let segment: Option<_> = try { | ||
| if !segment.infer_args || generics.has_impl_trait() { |
Member
Author
There was a problem hiding this comment.
Since this one didn't have any ? inside the try, my instinct was that just using None instead of do yeet; was more direct.
Member
|
I think that in a lot of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left a few, like
where it felt like seeing it might still be useful for the reader.
Feel free to push back on any of these changes if you think they should be left alone.