-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Remove generics from DepGraph
#151982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove generics from DepGraph
#151982
Conversation
This comment has been minimized.
This comment has been minimized.
26d91f0 to
b15eeea
Compare
This comment has been minimized.
This comment has been minimized.
b15eeea to
057eced
Compare
This comment has been minimized.
This comment has been minimized.
4316c71 to
e481572
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Remove generics from `DepGraph`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (1f642ee): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 8.9%, secondary 1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.737s -> 471.042s (-0.57%) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
Remove generics from `DepGraph`
This comment has been minimized.
This comment has been minimized.
e481572 to
3ebaa8b
Compare
This removes generics from
DepGraphby predefining some properties of dep kinds inrustc_query_system.DEP_KIND_NULL,DEP_KIND_RED,DEP_KIND_SIDE_EFFECTandDEP_KIND_ANON_ZERO_DEPSget their indices assigned inrustc_query_systemand the bits needed to encode dep kinds is also hardcoded there. These are checked later inrustc_middle.read_index,assert_ignoredandwith_ignoreare redefined onDepContextto avoid manual passing of theDepstype.