-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Use DEVELOPER_DIR instead of a custom xcode-select script
#152012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors try jobs=dist-x86_64-apple,dist-apple-various,dist-aarch64-apple,aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script try-job: dist-x86_64-apple try-job: dist-apple-various try-job: dist-aarch64-apple try-job: aarch64-apple
|
Seems like a nice win! @bors delegate |
|
✌️ @madsmtm, you can now approve this pull request! If @shepmaster told you to " |
|
Hmm, not that good at bors commands, maybe it wants: @bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script try-job: *apple*
|
The error seems to be that GitHub Actions was down. @bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script try-job: *apple*
|
@bors r=shepmaster rollup |
|
📋 Only open, non-draft PRs can be approved. |
|
@bors r=shepmaster rollup |
|
Wow, I really fudged around with bors in this one |
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script `DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`. Using this makes reproducing things locally a little easier (you can just copy the env var). r? shepmaster
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script `DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`. Using this makes reproducing things locally a little easier (you can just copy the env var). r? shepmaster
…uwer Rollup of 13 pull requests Successful merges: - #152034 (Show largest job duration changes in hours and minutes in the post-merge report) - #152039 (coverage: Add a test case for a previously-unknown span mismatch) - #152045 (Convert to inline diagnostics in `rustc_infer`) - #149263 (Forbid manual `Unpin` impls for structurally pinned types) - #151754 (Check proj's parent is trait or not when checking dyn compatibility) - #151848 (Port `rustc_mir` to attribute parser) - #151874 (error on unsized AnonConsts) - #151944 (Convert to inline diagnostics in `rustc_attr_parsing`) - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script) - #152019 (`NativeLib` cleanups) - #152029 (disable socket tests in Miri) - #152041 (Convert to inline diagnostics in `rustc_query_system`) - #152050 (Try to fix `rustdoc-gui/globals.goml` flakyness) Failed merges: - #152046 (Use glob imports for attribute parsers)
`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`.
5e0e0a9 to
19e4108
Compare
|
Ah, of course, sorry about that - I really should've blessed the test, instead of hoping I could just modify it manually. @bors r=shepmaster rollup |
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script `DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`. Using this makes reproducing things locally a little easier (you can just copy the env var). r? shepmaster
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script `DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`. Using this makes reproducing things locally a little easier (you can just copy the env var). r? shepmaster
…uwer Rollup of 7 pull requests Successful merges: - #148967 (const-eval: always do mem-to-mem copies if there might be padding involved) - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script) - #152044 (Convert to inline diagnostics in `rustc_incremental`) - #152046 (Use glob imports for attribute parsers) - #152054 (Distinguish error message for `#[diagnostic::on_const]` on const trait impls) - #152059 (Fix some autodiff tests require Clto=fat) - #152073 (Convert to inline diagnostics in `rustc_mir_dataflow`)
DEVELOPER_DIRis the standard environment variable for overriding the Xcode version, there is no need to invokexcode-select --switchmanually to do this.The variable is documented in both
man xcode-selectandman xcrun.Using this makes reproducing things locally a little easier (you can just copy the env var).
r? shepmaster