Skip to content

Conversation

@madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Feb 2, 2026

DEVELOPER_DIR is the standard environment variable for overriding the Xcode version, there is no need to invoke xcode-select --switch manually to do this.

The variable is documented in both man xcode-select and man xcrun.

Using this makes reproducing things locally a little easier (you can just copy the env var).

r? shepmaster

@madsmtm madsmtm added O-macos Operating system: macOS T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-CI Area: Our Github Actions CI O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) labels Feb 2, 2026
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 2, 2026

@bors try jobs=dist-x86_64-apple,dist-apple-various,dist-aarch64-apple,aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script


try-job: dist-x86_64-apple
try-job: dist-apple-various
try-job: dist-aarch64-apple
try-job: aarch64-apple
@shepmaster
Copy link
Member

Seems like a nice win!

@bors delegate

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

✌️ @madsmtm, you can now approve this pull request!

If @shepmaster told you to "r=me" after making some further change, then please make that change and post @bors r=shepmaster.

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

💔 Test for 588930e failed: CI

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 2, 2026

Hmm, not that good at bors commands, maybe it wants:

@bors try jobs=apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script


try-job: *apple*
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

💔 Test for 2a52f41 failed: CI

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 2, 2026

The error seems to be that GitHub Actions was down.

@bors try jobs=apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script


try-job: *apple*
@madsmtm madsmtm closed this Feb 3, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 3, 2026
@madsmtm madsmtm reopened this Feb 3, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2026
@madsmtm madsmtm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

☀️ Try build successful (CI)
Build commit: c570eb5 (c570eb54a95ab9effb29d3289114aba63fdc39df, parent: f60a0f1bcc5a2a6dd8eb2d2021da79b40f5fbae9)

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

@bors r=shepmaster rollup

@madsmtm madsmtm closed this Feb 3, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

📋 Only open, non-draft PRs can be approved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 3, 2026
@madsmtm madsmtm reopened this Feb 3, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2026
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

@bors r=shepmaster rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

📌 Commit 5e0e0a9 has been approved by shepmaster

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

Wow, I really fudged around with bors in this one

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 3, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script

`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this.

The variable is documented in both `man xcode-select` and `man xcrun`.

Using this makes reproducing things locally a little easier (you can just copy the env var).

r? shepmaster
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 3, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script

`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this.

The variable is documented in both `man xcode-select` and `man xcrun`.

Using this makes reproducing things locally a little easier (you can just copy the env var).

r? shepmaster
rust-bors bot pushed a commit that referenced this pull request Feb 3, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #152034 (Show largest job duration changes in hours and minutes in the post-merge report)
 - #152039 (coverage: Add a test case for a previously-unknown span mismatch)
 - #152045 (Convert to inline diagnostics in `rustc_infer`)
 - #149263 (Forbid manual `Unpin` impls for structurally pinned types)
 - #151754 (Check proj's parent is trait or not when checking dyn compatibility)
 - #151848 (Port `rustc_mir` to attribute parser)
 - #151874 (error on unsized AnonConsts)
 - #151944 (Convert to inline diagnostics in `rustc_attr_parsing`)
 - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script)
 - #152019 (`NativeLib` cleanups)
 - #152029 (disable socket tests in Miri)
 - #152041 (Convert to inline diagnostics in `rustc_query_system`)
 - #152050 (Try to fix `rustdoc-gui/globals.goml` flakyness)

Failed merges:

 - #152046 (Use glob imports for attribute parsers)
@JonathanBrouwer
Copy link
Contributor

@bors r-
#152055 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

Commit 5e0e0a9 has been unapproved.

This PR was contained in a rollup (#152055), which was also unapproved.

`DEVELOPER_DIR` is the standard environment variable for overriding the
Xcode version, there is no need to invoke `xcode-select --switch`
manually to do this.

The variable is documented in both `man xcode-select` and `man xcrun`.
@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 3, 2026

@bors r- #152055 (comment)

Ah, of course, sorry about that - I really should've blessed the test, instead of hoping I could just modify it manually.

@bors r=shepmaster rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 3, 2026

📌 Commit 19e4108 has been approved by shepmaster

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 3, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script

`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this.

The variable is documented in both `man xcode-select` and `man xcrun`.

Using this makes reproducing things locally a little easier (you can just copy the env var).

r? shepmaster
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 3, 2026
Use `DEVELOPER_DIR` instead of a custom `xcode-select` script

`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this.

The variable is documented in both `man xcode-select` and `man xcrun`.

Using this makes reproducing things locally a little easier (you can just copy the env var).

r? shepmaster
rust-bors bot pushed a commit that referenced this pull request Feb 4, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #148967 (const-eval: always do mem-to-mem copies if there might be padding involved)
 - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script)
 - #152044 (Convert to inline diagnostics in `rustc_incremental`)
 - #152046 (Use glob imports for attribute parsers)
 - #152054 (Distinguish error message for `#[diagnostic::on_const]` on const trait impls)
 - #152059 (Fix some autodiff tests require Clto=fat)
 - #152073 (Convert to inline diagnostics in `rustc_mir_dataflow`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-macos Operating system: macOS S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants