Convert to inline diagnostics in rustc_borrowck#152107
Open
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Open
Convert to inline diagnostics in rustc_borrowck#152107JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
rustc_borrowck#152107JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
5 tasks
lqd
reviewed
Feb 4, 2026
| .is_some() | ||
| { | ||
| diag.span_note(bound.span, fluent::borrowck_limitations_implies_static); | ||
| diag.span_note(bound.span, inline_fluent!("due to a current limitation of the type system, this implies a `'static` lifetime")); |
Member
There was a problem hiding this comment.
a slight downside in inlining the fluent message is sometimes we're using them more than once, like here and at line 702.
Contributor
Author
There was a problem hiding this comment.
Ah this one should be fixable, just gotta make a const out of it. Done :)
JonathanBrouwer
force-pushed
the
convert_borrowck
branch
from
c74649d to
3852fd9
Compare
Member
|
I'll also take this one, r? me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #151366
r? @jdonszelmann