Hard code DEFAULT_LOCALE_RESOURCES in rustc_interface#152137
Open
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Open
Hard code DEFAULT_LOCALE_RESOURCES in rustc_interface#152137bjorn3 wants to merge 1 commit intorust-lang:mainfrom
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use |
5 tasks
This comment has been minimized.
This comment has been minimized.
locale_resources will no longer be used at all soon, so no need for custom drivers to have the ability to define their own locale_resources. Also hard code report_ice to not use any locale resources. It only emits diagnostics that have already been ported to inline fluent messages.
bjorn3
force-pushed
the
driver_fixed_locale_resources
branch
from
8f3dce7 to
dbf46f0
Compare
bjorn3
commented
Feb 4, 2026
|
|
||
| // Create a Parser. | ||
| let psess = ParseSess::new(rustc_driver::DEFAULT_LOCALE_RESOURCES.to_vec()); | ||
| let psess = ParseSess::new(vec![]); |
Member
Author
There was a problem hiding this comment.
I think this is fine as we cancel all errors below rather than emit them.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
I'd like to wait a few days with merging this until the spam of diagnostics convert PRs has calmed down, as this will conflict with all of them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locale_resources will no longer be used at all soon, so no need for custom drivers to have the ability to define their own locale_resources. Also hard code report_ice to not use any locale resources. It only emits diagnostics that have already been ported to inline fluent messages.
Part of #151366, cc @JonathanBrouwer