-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Include library/stdarch for CURRENT_RUSTC_VERSION updates
#152188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
(cherry picked from commit b901497)
|
cc @Amanieu, @folkertdev, @sayantn |
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
The tool is the most relevant part to review. r? release |
|
r? emilyalbini |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other paths we should include for this? Maybe clippy or rustfmt or something like that?
|
I only found one time that clippy has used this in commit 5f26d0e, which still lingers today -- that ought to be 1.88.0 I guess. I'm not sure if that version is surfaced to the user anywhere though, so I don't know if the build-time replacement is working in that context either. I didn't find any history of |
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
I just fixed that single clippy instance, but I don't think we should add that path to |
Our tool
replace-version-placeholderuses thetidyfile walker and itsdirectory filter, but that skips
library/stdarchwhich we do need for publicstability markers. This PR adds a local filter function that explicitly allows
that path.
The commit for 1.94
stdarchupdates is coming from beta #152187.