[bootstrap]: Add Step::is_supported abstraction
#152201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
Member
Author
|
i think to fix this failure properly i'd have to add a |
Member
you could set that as base branch using github ui (and it will automatically shift to main branch if that pr gets merged) |
jyn514
force-pushed
the
bootstrap-is-supported
branch
from
0f3bced to
78dc5be
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
this doesn't seem to work across forks unfortunately :/ |
Member
|
This seems pretty interesting! I mostly examined the second commit to see how it would affect the existing steps. Some initial comments:
|
Member
Author
|
Some answers in no particular order: I think combining this with Perhaps the
oh, hm ... yes, that is what's happening. I agree that it would be nice to combine these three ( Originally I had tried to define enum SupportStatus<Output = (), Input = ()> {
Supported(Input),
Warn(Input),
Skip(Output),
Fatal,
}That allows the logic to be shared between The problem here is that it plays hell with Now, I've thought about combining But on the other hand, if we immediately call I'm not sure what a good approach here is. I'll think about it for a while, maybe someone else will come up with a good idea in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is mostly intended to generate discussion. I do not expect these changes to land as-is.
This is built on top of #151930 for convenience. The new commits start with 640e87c.
The first commit adds the new abstraction; the second converts many existing Steps to use it, to give an idea of what it looks like.
See #t-infra/bootstrap > Path filters in bootstrap @ 💬 for previous discussion.
What problems does this solve?
Right now there’s a bunch of adhoc logic to decide whether a Step should be skipped/warn/exit/treated as a default. Usually that logic is related to if some bootstrap tool is missing or whether some config is enabled. It tends to be inconsistent between Steps: some remember to put it in
is_default, some don't. Some unconditionally run the Step and exit with an error if the prerequisite is missing; others silently skip the step.What is the new API?
What is the new behavior?
After this change, all steps choose from one of the following four options. For all options,
Err(_)implies that the step is skipped frommake_run; the error variants only matter forensure.Ok(()): The step is supported. There is no additional default condition.Err(Unsupported::Skip): Return the dummy output passed back in the enum.Err(Unsupported::Warn): Warn, but execute the step anyway.Err(Unsupported::Fatal): Immediately exit.Example output
skip:
warn:
fatal: