[DO NOT MERGE] Method receiver lint

[BennoLossin]

This is implementing the lint described in #151583. The plan is to run a crater run on this lint before deciding on how to add this to the language.

An important detail that I noticed when implementing was that it must recursively look at the target type. Since dereferencing to a concrete type that then derefs to a generic has the same problem.

[rustbot]

Error: Label needs-crater can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

[rustbot]

Error: Label needs-crater can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

[BennoLossin]

@rustbot label +I-lang-nominated

[rust-log-analyzer]

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    b72a662c47e3   6 days ago   790MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:57ef9cc45f72cc4258ee1baa8243bc3cd55c0a0e570b6768c37346247be35f0d
deleted: sha256:b72a662c47e31df2e7bf59368b2b83be239f02a1baa721393717711a1a719df9
deleted: sha256:3e13ccd80f19769f39008cfc6549938e1ea4905f47b028c1df2dd6085191386c
deleted: sha256:842807995a512b2c5a9b241a3aecdbe79af6b0642d96fa5460cfcf0c9d8be295
deleted: sha256:0f9074b9f46f4570eb7cb4b65fcb3c3d909f9b1d14ca66b30508117b6deda303
deleted: sha256:2ca99cb9251d19157c56b5d91c8961bb4b35196a5ca9b4ffdccbf24abbfe2a5f
---
    |
124 |     pub fn as_ref(&self) -> InternedRef<'_, T> {
    |                   ^^^^^
...
188 | impl<T: Internable> Deref for Interned<T> {
    | ----------------------------------------- trait implemented here
189 |     type Target = T;
    |     ----------- with `Target` set here
    |
    = note: `#[warn(inherent_method_on_receiver)]` on by default

warning: inherent methods on types that implement `Deref` or `Receiver` shadow methods of their target
   --> src/tools/rust-analyzer/crates/intern/src/intern.rs:223:19
    |
223 |     pub fn as_raw(self) -> *const T {
    |                   ^^^^
...
300 | impl<T> Deref for InternedRef<'_, T> {
    | ------------------------------------ trait implemented here
301 |     type Target = T;
    |     ----------- with `Target` set here

warning: inherent methods on types that implement `Deref` or `Receiver` shadow methods of their target
   --> src/tools/rust-analyzer/crates/intern/src/intern.rs:238:21
    |
238 |     pub fn to_owned(self) -> Interned<T> {
    |                     ^^^^
...
300 | impl<T> Deref for InternedRef<'_, T> {
    | ------------------------------------ trait implemented here
301 |     type Target = T;
    |     ----------- with `Target` set here

warning: inherent methods on types that implement `Deref` or `Receiver` shadow methods of their target
   --> src/tools/rust-analyzer/crates/intern/src/intern.rs:243:16
    |
243 |     pub fn get(self) -> &'a T {
    |                ^^^^
...
300 | impl<T> Deref for InternedRef<'_, T> {
    | ------------------------------------ trait implemented here
301 |     type Target = T;
    |     ----------- with `Target` set here

warning: inherent methods on types that implement `Deref` or `Receiver` shadow methods of their target
   --> src/tools/rust-analyzer/crates/intern/src/intern.rs:252:38
    |
252 |     pub unsafe fn decrement_refcount(self) {
    |                                      ^^^^
...
300 | impl<T> Deref for InternedRef<'_, T> {
    | ------------------------------------ trait implemented here
301 |     type Target = T;
    |     ----------- with `Target` set here

warning: inherent methods on types that implement `Deref` or `Receiver` shadow methods of their target
   --> src/tools/rust-analyzer/crates/intern/src/intern.rs:267:32
    |
267 |     pub fn change_lifetime<'b>(self) -> InternedRef<'b, T> {
    |                                ^^^^
...
300 | impl<T> Deref for InternedRef<'_, T> {
    | ------------------------------------ trait implemented here
301 |     type Target = T;
    |     ----------- with `Target` set here

[RUSTC-TIMING] semver test:false 0.427
[RUSTC-TIMING] expect_test test:false 0.295

[Nadrieril]

This feels like you could end up in an infinite loop, e.g.

impl Deref for StructA {
  type Target = StructB;
}
impl Deref for StructB {
  type Target = StructA;
}

That doesn't matter for the crater run tho

[dingxiangfei2009]

Maybe we could use recursion limit: tcx.recursion_limit().value_within_limit(..)

[Nadrieril]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 7b3da91 (7b3da9103634dffd4f4365cfd8642427c781d99f, parent: 035b01b794602d5861daa43ac792f372f8981ed7)