Report unconstrained region in hidden types lazily #152218
Draft
+180
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
adwinwhite
commented
Feb 6, 2026
|
|
||
| type MultiUse2 = impl Sized; | ||
| #[define_opaque(MultiUse2)] | ||
| fn capture_different_universals_not_on_bounds<'a, 'b, 'c>(a: &'a i32, b: &'b i32, c: &'c i32) { |
Contributor
Author
There was a problem hiding this comment.
Just make sure that we report error for each invalid capture.
In my other attempt, only one unconstrained error per opaque definition is reported.
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/trait-system-refactor-initiative#264
I didn't copy the mechanism of HIR typeck as I found that we just need to be lax in the unconstrained region case.
It already ignores non-defining uses and invalid params.
This fixes
ukanrenandcodecrafters-redis-rustbut not #151322 and #151323.Looking at the backtraces of them, the ICEs are triggered in HIR typeck so probably a different issue.Edited: now that I looked at these two issues closer, they seem related. I probably missed something important.
And I'm having trouble coming up with more complex tests. 🙁
r? @lcnr