Skip to content

doc attribute parsing errors: Revert #151952 #152221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GuillaumeGomez wants to merge 4 commits into
base: main
Choose a base branch
from
Open

doc attribute parsing errors: Revert #151952 #152221

GuillaumeGomez wants to merge 4 commits into from

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 6, 2026 •
edited by rustbot
Loading

Reverts #151952.

Since it's now backported with the "future error" warning, we can remove these changes.

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 6, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 6, 2026

Can we add tests for the three cases in #151865 (comment)
After that I think this needs T-rustdoc approval since it's a breaking change
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 6, 2026
Closed
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Feb 6, 2026

Added the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @rustbot @JonathanBrouwer