Skip to content

Add must_use for FileTimes #152232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add must_use for FileTimes #152232

chenyukang wants to merge 1 commit into from
+3 −0

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Feb 6, 2026 •
edited by rustbot
Loading

Fixes #152231

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from ChrisDenton, Mark-Simulacrum, jhpratt

eggyal

This comment was marked as resolved.

Sign in to view

@chenyukang chenyukang force-pushed the add-must-use-for-filetimes branch from 36e8498 to b1ae169 Compare February 6, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eggyal eggyal eggyal requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FileTimes::set_modified does not modify the time, but returns FileTimes

4 participants

@chenyukang @rustbot @eggyal @Mark-Simulacrum