Uplift Predicate::allow_normalization to rustc_type_ir
#152396
+28
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Member
Author
|
Looks like GitHub is in an ourtrage 🤔 I'll re-trigger the CI tomorrow |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
lcnr
reviewed
Feb 9, 2026
| /// | ||
| /// Wf predicates must not be normalized, as normalization | ||
| /// can remove required bounds which would cause us to | ||
| /// unsoundly accept some programs. See #91068. |
Contributor
There was a problem hiding this comment.
iirc we don't move comments for duplicated methods, could look at a few other methods to check.
please keep the comment in rustc_middle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this FIXME comment while fixing a bug in rust-analyzer 😄
cc rust-lang/rust-analyzer#21611
r? types