Skip to content

Partially revert "resolve: Update NameBindingData::vis in place" #152498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
petrochenkov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Partially revert "resolve: Update NameBindingData::vis in place" #152498

petrochenkov wants to merge 2 commits into from
+48 −2

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 11, 2026 •
edited
Loading

Partial revert of 227e7bd.
This is a minimal fix for backporting to beta, I'll submit proper fixes later.

Fixes #152004
Fixes #151124
Fixes #152347

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2026
@petrochenkov petrochenkov marked this pull request as ready for review February 11, 2026 19:34
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 67 candidates
  • Random selection from 15 candidates

This was referenced Feb 11, 2026
Open
Open
Open
Closed
@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

3 participants

@petrochenkov @rustbot @jieyouxu