Fix(lib/win/net): Strip UDS away under Win7#152534
Open
PaulDance wants to merge 1 commit intorust-lang:mainfrom
Open
Fix(lib/win/net): Strip UDS away under Win7#152534PaulDance wants to merge 1 commit intorust-lang:mainfrom
PaulDance wants to merge 1 commit intorust-lang:mainfrom
Conversation
Unix Domain Socket support has only been added to Windows since Windows 10 Insider Preview Build 17063. Thus, it has no chance of ever being supported under Windows 7, making current tests fail. This therefore strips it entirely away from the Win7 target using `cfg` gates where appropriate. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
rustbot
added
O-windows
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix Domain Socket support has only been added to Windows since Windows 10 Insider Preview Build 17063. Thus, it has no chance of ever being supported under Windows 7, making current tests fail. This therefore strips it entirely away from the Win7 target using
cfggates where appropriate.cc #150487 @roblabla
@rustbot label T-libs A-io O-windows-7