Skip to content

privacy: Fix type privacy holes when it doesn't cause too much breakage#152543

Open
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:rprivtit2
Open

privacy: Fix type privacy holes when it doesn't cause too much breakage#152543
petrochenkov wants to merge 1 commit intorust-lang:mainfrom
petrochenkov:rprivtit2

Conversation

@petrochenkov
Copy link
Contributor

A subset of #146470.

Private types in RPITITs now report hard errors.
Private types in bounds of associated types still only report the private_bounds lint due to unacceptable amount of breakage (#146470 (comment)).

Closes #144139

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 12, 2026
@petrochenkov
Copy link
Contributor Author

@bors try

rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
privacy: Fix type privacy holes when it doesn't cause too much breakage
@rust-bors

This comment has been minimized.

@petrochenkov
Copy link
Contributor Author

TODO: @craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-146470-3/retry-regressed-list.txt

@petrochenkov petrochenkov marked this pull request as ready for review February 12, 2026 15:38
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 16 candidates

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

☀️ Try build successful (CI)
Build commit: fcfb0ff (fcfb0ffc7ed7fc631df1136063939ef648434735, parent: 7ad4e69ad585d8ff214f7b42d01f1959eda08f40)

@petrochenkov
Copy link
Contributor Author

@craterbot
Copy link
Collaborator

👌 Experiment pr-152543 created and queued.
🤖 Automatically detected try build fcfb0ff
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-152543 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I-lang-radar Items that are on lang's radar and will need eventual work or consideration. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(re-)Fix private-in-public for RPITIT

5 participants