Oneshot is_ready
#152557
Open
Oneshot is_ready
#152557
+78
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Adds an `is_ready` method to `oneshot::Receiver` that allows a user to see if a value has been sent over the channel. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
rustbot
added
S-waiting-on-review
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
connortsui20
commented
Feb 12, 2026
Comment on lines
+283
to
+286
| /// Returns `true` when the channel is disconnected. | ||
| pub(crate) fn is_disconnected(&self) -> bool { | ||
| self.inner.lock().is_disconnected | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It's somewhat unfortunate that this has to take the lock. I believe it might be possible to outline the is_disconnected flag as an atomic bool outside of the lock, but that might not be worth the extra complexity.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #143674
Adds a
is_readymethod to theoneshot::Receiver.This also changes the internal mutex for the
mpmc::zeroflavor implementation to use thenonpoison::Mutexsince every lock call simplyunwraps. Please let me know if that is out of the scope of this change.There's also one small unfortunate implementation detail, see comments below.