Avoid empty extra-arg suggestion spans in macro calls#152634
Open
TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
Open
Avoid empty extra-arg suggestion spans in macro calls#152634TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? compiler |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152414
Fixes #131762
When building
Error::Extraremoval suggestions, we extended spans withtoanduntileven when syntax contexts differed inlabels_and_suggestion_text. In macro-expanded calls this could fall back to an empty span and triggering an ICE.I fixed it to combine spans only when contexts match.