Draft
Conversation
rustbot
added
S-waiting-on-author
Jamesbarford
force-pushed
the
chore/move-more-types-to-ir
branch
from
3ef4cf0 to
c64839d
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
lcnr
reviewed
Feb 16, 2026
| write!(p, ")")?; | ||
| if let Some(ty) = return_ty.skip_binder().as_type() { | ||
| if !ty.is_unit() { | ||
| if !matches!(ty.kind(), ty::Tuple(tys) if tys.is_empty()) { |
lcnr
reviewed
Feb 16, 2026
| where | ||
| F: FnOnce(&mut Self) -> R; | ||
| pub trait TyEncoder<'tcx>: ir_codec::TyEncoder<'tcx, Interner = TyCtxt<'tcx>> {} | ||
| impl<'tcx, T> TyEncoder<'tcx> for T where T: ir_codec::TyEncoder<'tcx, Interner = TyCtxt<'tcx>> {} |
Contributor
There was a problem hiding this comment.
why does this trait have to be moved? This is surprising to me
Might be good to write in the PR description what you're moving and why.
As in, sth like
- moving
Ty - also uses other types
Xwhich now need to be moved - has function which relies on
tcx, add methodfn XXXtotrait Interner
lcnr
reviewed
Feb 16, 2026
| /// `Decodable` can still be implemented in cases where `Decodable` is required | ||
| /// by a trait bound. | ||
| pub trait RefDecodable<'tcx, D: TyDecoder<'tcx>>: PointeeSized { | ||
| pub trait RefDecodable<'tcx, D: TyDecoder<'tcx>>: std::marker::PointeeSized { |
lcnr
reviewed
Feb 16, 2026
| feature = "nightly", | ||
| derive(Encodable_NoContext, Decodable_NoContext, HashStable_NoContext) | ||
| )] | ||
| #[cfg_attr(feature = "nightly", derive(HashStable_NoContext))] |
lcnr
reviewed
Feb 16, 2026
| #[rustc_diagnostic_item = "Ty"] | ||
| #[rustc_pass_by_value] | ||
| #[rustc_has_incoherent_inherent_impls] | ||
| pub struct Ty<I: Interner>(pub I::Interned<WithCachedTypeInfo<TyKind<I>>>); |
Contributor
There was a problem hiding this comment.
should be in a mod ty or mod sty to mirror rustc_middle
lcnr
reviewed
Feb 16, 2026
| #[cfg_attr(feature = "nightly", derive(HashStable_NoContext))] | ||
| #[rustc_diagnostic_item = "Ty"] | ||
| #[rustc_pass_by_value] | ||
| #[rustc_has_incoherent_inherent_impls] |
Contributor
There was a problem hiding this comment.
dubious :3 i guess that's a way to simply the migration. Removing this before merge/add a TODO rn
lcnr
reviewed
Feb 16, 2026
| #[inline] | ||
| pub fn interned(self) -> I::Interned<WithCachedTypeInfo<TyKind<I>>> { | ||
| self.0 | ||
| } |
lcnr
reviewed
Feb 16, 2026
| } | ||
|
|
||
| #[inline] | ||
| #[allow(rustc::pass_by_value)] |
lcnr
reviewed
Feb 16, 2026
|
|
||
| impl<I: Interner> TypeSuperVisitable<I> for Ty<I> | ||
| where | ||
| I::Interned<WithCachedTypeInfo<TyKind<I>>>: Deref<Target = WithCachedTypeInfo<TyKind<I>>>, |
Contributor
There was a problem hiding this comment.
should be item bound of I::Interned, same with all other where-bounds here
lcnr
reviewed
Feb 16, 2026
| I::Region: TypeFoldable<I> + TypeVisitable<I>, | ||
| I::Term: From<Ty<I>>, | ||
| I::Tys: TypeFoldable<I> + TypeVisitable<I>, | ||
| I::Interned<WithCachedTypeInfo<TyKind<I>>>: |
lcnr
reviewed
Feb 16, 2026
| /// This offset is also chosen so that the first byte is never < 0x80. | ||
| pub const SHORTHAND_OFFSET: usize = 0x80; | ||
|
|
||
| pub trait TyEncoder<'tcx>: SpanEncoder { |
Contributor
There was a problem hiding this comment.
this feels rustc specific and is not used by r-a afaik, so I'd prefer keeping this in rustc_middle for now
lcnr
reviewed
Feb 16, 2026
| } | ||
|
|
||
| pub trait Interned<T>: Clone + Copy + Hash + PartialEq + Eq + Debug { | ||
| fn new_unchecked(t: &T) -> Self; |
Contributor
There was a problem hiding this comment.
🤔 where is that used, surprising that we'd ever want to use this in rustc_next_trait_solver
lcnr
reviewed
Feb 16, 2026
| + Hash | ||
| + Eq | ||
| + PartialEq | ||
| + Deref<Target = T>; |
Contributor
There was a problem hiding this comment.
should be a super trait bounds of a single Interned trait
lcnr
reviewed
Feb 16, 2026
| #![cfg_attr(feature = "nightly", rustc_diagnostic_item = "type_ir")] | ||
| // tidy-alphabetical-start | ||
| #![allow(rustc::direct_use_of_rustc_type_ir)] | ||
| #![allow(rustc::pass_by_value)] |
lcnr
reviewed
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? ghost