Skip to content

Fix wrong par_slice implementation#152717

Open
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
zetanumbers:fix-152375
Open

Fix wrong par_slice implementation#152717
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
zetanumbers:fix-152375

Conversation

@zetanumbers
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 14 candidates

@jieyouxu
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 16, 2026
Fix wrong par_slice implementation
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2026
@jieyouxu jieyouxu self-assigned this Feb 16, 2026
@JonathanBrouwer
Copy link
Contributor

cc @Zoxc @jieyouxu @lqd
Change looks good to me, r=me
I think we should redo the perf numbers

@JonathanBrouwer
Copy link
Contributor

I think last time rust-timer didn't show any perf impact, how were the statistics in that PR generated?

@lqd
Copy link
Member

lqd commented Feb 16, 2026

I think last time rust-timer didn't show any perf impact, how were the statistics in that PR generated?

Zoxc ran rcb and posted that; rustc-perf did show wall time improvements for the multithreaded benchmark we have.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 16, 2026

☀️ Try build successful (CI)
Build commit: 532510f (532510fc9b4953f08a24a2fd52f36860df85a645, parent: 71e00273c0921e1bc850ae8cc4161fbb44cfa848)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (532510f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.1% [-5.1%, -5.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 485.967s -> 483.907s (-0.42%)
Artifact size: 397.80 MiB -> 397.81 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants