Allow forbidden target features to be hard errors#152821
Open
wesleywiser wants to merge 1 commit intorust-lang:mainfrom
Open
Allow forbidden target features to be hard errors#152821wesleywiser wants to merge 1 commit intorust-lang:mainfrom
wesleywiser wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
a882953 to
31a3497
Compare
Member
|
Thanks! This has indeed come up a few times (e.g. if nothing else, in features that we have never really had people rely on and thus a FCW makes no sense). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes when adding a new target features to the list of known target features, we want to completely forbid them from being used because they are ABI affecting and should be target modifiers instead. As such, we want to issue an error rather than a warning since there are no future compatibility concerns .
r? @workingjubilee since you're familiar with the motivating case in #136597
If I rebase that PR on top of this locally, then we get the following error messages when trying to activate the SLS target feature (note that they are errors not warnings and we've omitted the usual note about future compatibility):